[ORLinux] [ORToolChain][Patch] General endian support for GCC

[Giuseppe Scrivano]

Liu <proljc at gmail.com> writes:

> General endian support for GCC, it is done:)

awesome!  Just some minor comments...

> diff --git a/gcc/ChangeLog.or32 b/gcc/ChangeLog.or32
> index a3467dd..2e6ce39 100644
> --- a/gcc/ChangeLog.or32
> +++ b/gcc/ChangeLog.or32
> @@ -1,3 +1,10 @@
> +2011-04-16  Jia Liu  <proljc at gmail.com>
> +
> +	* gcc/config.gcc: Add general endain support.
> +	* config/or32/or32.h: Add general endain support.
> +	* gcc/config/or32/or32.opt: Add general endain support.
> +	* gcc/config/or32/default.h: Add general endain support.

Beside the small typo, s|endain|endian|, wouldn't be better to be more
descriptive here?  You can get an idea from other changelog entries.



> diff --git a/gcc/config/or32/default.h b/gcc/config/or32/default.h
> index f68975d..7ba1115 100644
> --- a/gcc/config/or32/default.h
> +++ b/gcc/config/or32/default.h
> @@ -62,8 +62,8 @@ the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.  */
>     the target makefile fragment or if none of the options listed in
>     `MULTILIB_OPTIONS' are set by default.  *Note Target Fragment::.  */
>  
> -#undef	MULTILIB_DEFAULTS
> -#define	MULTILIB_DEFAULTS { "mbig", "mcall-linux" }
> +/*#undef	MULTILIB_DEFAULTS
> +#define	MULTILIB_DEFAULTS { "mbig", "mcall-linux" }*/

If this code is not needed, better drop it.


Cheers,
Giuseppe